Skip to content

gh-53950: Clear MESSAGES in msgfmt#133316

Open
StanFromIreland wants to merge 4 commits into
python:mainfrom
StanFromIreland:msgfmt-clear
Open

gh-53950: Clear MESSAGES in msgfmt#133316
StanFromIreland wants to merge 4 commits into
python:mainfrom
StanFromIreland:msgfmt-clear

Conversation

@StanFromIreland

@StanFromIreland StanFromIreland commented May 2, 2025

Copy link
Copy Markdown
Member

@tomasr8

tomasr8 commented May 2, 2025

Copy link
Copy Markdown
Member

What would be even better is not having a global variable at all, though that would be a larger change and is already partially covered by #10875 I believe.

Comment thread Lib/test/test_tools/test_msgfmt.py Outdated
@StanFromIreland

Copy link
Copy Markdown
Member Author

We can just clear it for now, till the larger change is merged.

@StanFromIreland

Copy link
Copy Markdown
Member Author

Also request @serhiy-storchaka

@merwok merwok requested a review from serhiy-storchaka May 2, 2025 20:03
Comment thread Tools/i18n/msgfmt.py Outdated
@merwok

merwok commented May 2, 2025

Copy link
Copy Markdown
Member

I am unsure about the better fix here. Why not eliminate the global variable if that fixes the problem? Then it will make the other PR smaller.

@StanFromIreland

Copy link
Copy Markdown
Member Author

@merwok I updated the PR with that if that is what you prefer, it is not too bad, the diff is pretty low.

@StanFromIreland StanFromIreland requested a review from merwok May 2, 2025 20:15
@serhiy-storchaka

Copy link
Copy Markdown
Member

Sharing MESSAGES between files is a (mis-)feature. See #10875 which solves this problem more thoroughly.

Comment thread Tools/i18n/msgfmt.py Outdated
@StanFromIreland

Copy link
Copy Markdown
Member Author

Do you mind splitting it from the larger pr, it would simplify it as Eric mentioned.

@github-actions

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Apr 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting core review stale Stale PR or inactive for long period of time.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants